From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Nov 2008 19:05:19 GMT
Subject: Re: [PATCH] sha1_file: make sure correct error is propagated
Message-ID: <7vfxlu9lhs.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1226655681.17731.4.camel@maia.lan>

Sam Vilain <sam@vilain.net> writes:

> Subject: sha1_file: accept EACCESS as equivalent to EPERM
>
> This was testing for 'Operation not permitted' rather than any kind
> of 'Permission Denied' error; prefer EACCESS.
>     
> Signed-off-by: Sam Vilain <sam@vilain.net>
> --
>   Sorry for the inevitable wrapping/whitespace fail :(
>
> diff --git a/sha1_file.c b/sha1_file.c
> index 7662330..cd422e6 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2231,7 +2231,7 @@ static int create_tmpfile(char *buffer, size_t
> bufsiz, const char *filename)
>  	memcpy(buffer, filename, dirlen);
>  	strcpy(buffer + dirlen, "tmp_obj_XXXXXX");
>  	fd = mkstemp(buffer);
> -	if (fd < 0 && dirlen && (errno != EPERM)) {
> +	if (fd < 0 && dirlen && (errno != EACCESS)) {

Is this accepting the two as equivalents???