From: Junio C Hamano Date: Sun, 18 Jan 2009 19:00:44 GMT Subject: Re: [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules Message-ID: <7vfxjgxwv7.fsf@gitster.siamese.dyndns.org> In-Reply-To: <8c5c35580901180837i6e835d98ob8875ce1b8ad3011@mail.gmail.com> Lars Hjemli writes: > I like the idea, but it will require thorough review of all > read_tree_recursive() consumers. So now we've got three different > approaches: > * me: global setting > * dscho: parameter to read_tree_recursive() > * you: accept the return value from the callback function > > Junio, what would you prefer? As usual René has the best taste in designing things ;-)