From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Mar 2009 09:42:09 GMT
Subject: Re: [PATCH] git-p4: improve performance with large files
Message-ID: <7vfxhrt2by.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090306085357.GA12880@zoy.org>

Sam Hocevar <sam@zoy.org> writes:

> On Thu, Mar 05, 2009, Han-Wen Nienhuys wrote:
>
>> i'd say
>> 
>>   data = []
>> 
>> add a comment that you're trying to save memory. There is no reason to
>> remove data from the namespace.
>
>    Okay. Here is an improved version.
>
> Signed-off-by: Sam Hocevar <sam@zoy.org>

Sorry, but that's not a commit log message, so signing it off does not add
much value to the patch.