From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Apr 2009 01:58:57 GMT
Subject: Re: [PATCH RFC3.5 05/12] send-email: Improve redability and error-handling in send_message's sendmail code
Message-ID: <7vfxg4nl0e.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vljpwp0jr.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Michael Witten <mfwitten@gmail.com> writes:
>
>> +
>> +		(my $pid = open my $pipe, '|-')
>> +			// die "Could not fork to run '$smtp_server': $!\n";
>
> Have I already rejected this "5.10 or later" construct in the previous
> round?  If I haven't, please consider now I have.

Sorry, I should have checked myself.  defined-or "//" is 5.8.1 or later.

Now the real question was if we still support anything older, and if so
what is the bottom version?

I certainly can go with "5.8.1 or later", but I vaguely recall during the
gitweb discussion we said anything without the utf-8 support is unusable
for gitweb, but I think we also said that the rest of the git codebase
should support running with something older (5.6.1, perhaps).

Anybody?