From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 18 Jun 2009 16:40:15 GMT
Subject: Re: [PATCH] add: allow configurations to be overriden by command line
Message-ID: <7vfxdxxzps.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1245316674-32377-1-git-send-email-bebarino@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

> Don't call git_config after parsing the command line options, otherwise
> the config settings will override any settings made by the command line.

Amusing.

This dates back to the original 0d78153 (Do "git add" as a builtin,
2006-05-17).  It had two git_config() calls (one before command line
parsing, and then another).

Then 11be42a (Make git-mv a builtin, 2006-07-26) noticed this duplicate
calls, and removed the wrong one.

The calling sequence has been the same ever since; parse-opt-ification
5c46f75 (Port builtin-add.c to use the new option parser., 2007-10-03) 
did not affect it either.

Perhaps this deserves a test.  It is an ancient breakage nobody noticed so
far.

Thanks