From: Junio C Hamano Date: Tue, 18 Aug 2009 19:40:43 GMT Subject: Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Message-ID: <7vfxbodi6c.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vk511dk11.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Another issue, especially with your "openssl sha1 removal" patch, is if we > can assume gcc everywhere. As far as I can tell, block-sha1/sha1.c will > be the first unconditional use of inline asm or statement expression on > i386/amd64. Are folks on Solaris and other platforms Ok with this? Ahhh, your bswap.h is a no-op unless you use gcc, so my worry was unfounded.