From: Junio C Hamano Date: Wed, 21 Oct 2009 22:30:35 GMT Subject: [PATCH 1/2] gc --auto --quiet: make the notice a bit less verboase Message-ID: <7vfx9cz8fo.fsf_-_@alter.siamese.dyndns.org> In-Reply-To: <4ADEC0DB.4000104@viscovery.net> When "gc --auto --quiet" decides there is something to do, it tells the user what it is doing, as it is going to make the user wait for a bit. But the message was a bit too long. Signed-off-by: Junio C Hamano --- Johannes Sixt writes: > I'm slightly in favor of adding "--quiet", because even with this option > we see some output: > > $ git gc --auto --quiet > Auto packing your repository for optimum performance. You may also > run "git gc" manually. See "git help gc" for more information. > > A compromise would be to reduce this message to the first sentence if > --quiet was given. builtin-gc.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/builtin-gc.c b/builtin-gc.c index 7d3e9cc..093517e 100644 --- a/builtin-gc.c +++ b/builtin-gc.c @@ -216,10 +216,13 @@ int cmd_gc(int argc, const char **argv, const char *prefix) */ if (!need_to_gc()) return 0; - fprintf(stderr, "Auto packing your repository for optimum " - "performance. You may also\n" - "run \"git gc\" manually. See " - "\"git help gc\" for more information.\n"); + fprintf(stderr, + "Auto packing the repository for optimum performance.%s\n", + quiet + ? "" + : (" You may also\n" + "run \"git gc\" manually. See " + "\"git help gc\" for more information.")); } else append_option(argv_repack, prune_expire && !strcmp(prune_expire, "now") -- 1.6.5.1.107.gba912