From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 31 Aug 2010 16:44:47 GMT
Subject: Re: [RFC] notes: avoid recommitting identical trees
Message-ID: <7vfwxud94w.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C7D2AAE.9000701@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

>>> +	if (!parent || parse_commit(parent->item) || parse_tree(parent->item->tree) ||
>>> +		hashcmp(parent->item->tree->object.sha1, tree_sha1)) {
>> 
>> I didn't check, but I can imagine you can drop the parse_tree here. We
>> should know the object sha1 once the commit is parsed.
>
> parse_commit() does a lookup_tree() but I don't think that it parses the
> tree, i.e. I don't hink it fills in tree->object.sha1.

Huh?  parse_tree(tree) calls read_sha1_file(tree->object.sha1) to parse
the tree.  How can it do without filling tree->object.sha1?