From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Sep 2010 17:54:33 GMT
Subject: Re: [PATCH] Make sure show_all_errors when using porcelain error messages
Message-ID: <7vfwxt5oyu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpq39ttxumz.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>>
>>> opts.show_all_errors controls the number of errors that can be displayed,
>>> and set_porcelain_error_msgs gives the format. But the formatting would
>>> be incorrect if set_porcelain_error_msgs is called without setting
>>> opts.show_all_errors.
>>
>> That makes it sound like a design bug of set_porcelain_error_msgs(), in
>> that the caller _cannot_ choose to stop at the first error if it wants to
>> use friendlier message than the plumbing one.
>
> You're right that the caller cannot stop at the first error and get
> friendly message, but I don't think this is a bug.

I am not saying it is a bug.  The description makes it sound like it is a
bug and I was wondering if it can be worded better not to do so.