From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Sep 2010 04:15:38 GMT
Subject: Re: [PATCH] get_author_ident_from_commit(): remove useless quoting
Message-ID: <7vfwwvn7o5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1285233730-30611-1-git-send-email-u.kleine-koenig@pengutronix.de>

Uwe Kleine-König  <u.kleine-koenig@pengutronix.de> writes:

> The command 's/'\''/'\''\'\'\''/g' only triples single quotes:
>
> 	$ echo "What's up?" | sed 's/'\''/'\''\'\'\''/g'
> 	What'''s up?
>
> This doesn't hurt as compared to a single single quote it only adds an
> empty string, but it makes the script needlessly complicated and hard to
> understand.

Interesting.  I think this was an ancient misconversion that dates back to
June 2005 ;-)

Thanks.