From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 29 Sep 2010 03:37:36 GMT
Subject: Re: [msysGit] Pull request for msysGit patches
Message-ID: <7vfwwtrzi7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4CA2A32E.3050802@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> I also normally avoid unportable 'export foo=bar'. In the particular
> case of GREP_OPTIONS, when commenting on my original patch submission,
> Dscho suggested 'test_have_prereq MINGW && export GREP_OPTIONS=foo' so
> that is the form which made it into the final patch.

Well, since bbc09c2 (grep: rip out support for external grep, 2010-01-12)
we do not run external grep at all, so GREP_OPTIONS is irrelevant.

Unless you are planning to run tests on installed version of git older
than v1.7.0, that is ;-).