From: Junio C Hamano Date: Fri, 17 Dec 2010 15:09:52 GMT Subject: Re: [PATCH 14/21] Convert ce_path_match() to use struct pathspec Message-ID: <7vfwtwjv0f.fsf@alter.siamese.dyndns.org> In-Reply-To: Nguyen Thai Ngoc Duy writes: >> I wonder if it makes more sense to change the type of revs->prune_data >> from an array of pointers to strings to a pointer to struct pathspec. >> Is there a downside? > > Converting a pointer to another pointer means mis typecasting can > happen and the compiler won't help catching them. You can rename the field at the same time, and the compiler will catch anything you forgot to touch, no?