From: Junio C Hamano Date: Tue, 30 Aug 2011 17:13:50 GMT Subject: Re: [PATCH 2/2] Add a remote helper to interact with mediawiki (fetch & push) Message-ID: <7vfwki3jqp.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110830035608.GB6647@elie.gateway.2wire.net> Jonathan Nieder writes: > Sverre Rabbelier wrote: >> On Mon, Aug 29, 2011 at 08:05, Junio C Hamano wrote: > >>> Does this exchange suggest that at least we would need an update to >>> documentation around "done", as Matthieu's "why is 'done' needed even >>> though I am not calling with --done?" sounds like a very fair question. >> >> No I think the documentation for fast-import is correct. > > However, the documentation for git-remote-helpers is hopelessly outdated. Good point. If somebody writes a working remote-helper using "import" to trigger fast-import as the back-end, and if it breaks because we changed the way fast-import is invoked and the helper needs to be updated, we at least need to give them a useful documentation that clearly states how the helper is expected to behave. > It does _not_ document recent changes; patches for that would > presumably come on top. Will queue this version for now, if only as a reminder that we would need more updates. Thanks.