From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 Oct 2011 00:00:38 GMT
Subject: Re: [PATCH v2 1/7] invalidate_ref_cache(): rename function from invalidate_cached_refs()
Message-ID: <7vfwj0iehl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1318235064-25915-2-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> It is the cache that is being invalidated, not the references.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---

Although I think one can say "ref cache is the container for cached refs"
and invalidating the "ref cache" as the container and invalidating the
"cached refs" as a collection mean essentially the same thing, probably
the new name makes more sense.

>  refs.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/refs.c b/refs.c
> index 2cb93e2..56e4254 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -223,7 +223,7 @@ static struct cached_refs *get_cached_refs(const char *submodule)
>  	return refs;
>  }
>  
> -static void invalidate_cached_refs(void)
> +static void invalidate_ref_cache(void)
>  {
>  	struct cached_refs *refs = cached_refs;
>  	while (refs) {
> @@ -1212,7 +1212,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
>  	ret |= repack_without_ref(refname);
>  
>  	unlink_or_warn(git_path("logs/%s", lock->ref_name));
> -	invalidate_cached_refs();
> +	invalidate_ref_cache();
>  	unlock_ref(lock);
>  	return ret;
>  }
> @@ -1511,7 +1511,7 @@ int write_ref_sha1(struct ref_lock *lock,
>  		unlock_ref(lock);
>  		return -1;
>  	}
> -	invalidate_cached_refs();
> +	invalidate_ref_cache();
>  	if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 ||
>  	    (strcmp(lock->ref_name, lock->orig_ref_name) &&
>  	     log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) {