From: Junio C Hamano Date: Fri, 10 Aug 2012 21:38:32 GMT Subject: Re: cherry-pick and 'log --no-walk' and ordering Message-ID: <7vfw7uig13.fsf@alter.siamese.dyndns.org> In-Reply-To: Martin von Zweigbergk writes: > There is also cherry-pick/revert, which I _think_ does not really want > the revisions sorted. Yes, I think sequencer.c::prepare_revs() is wrong to unconditoinally call prepare_revision_walk(). It instead should first check the revs->pending.objects list to see if what was given by the caller is a mere collection of individual objects or a range expression (i.e. check if any of them is marked with UNINTERESTING), and refrain from going into the body of the preparation steps, which has to involve sorting. I think we had to fix a bug in "git show" coming from a similar root cause, but the bug manifested in the opposite direction.