From: Junio C Hamano Date: Mon, 20 Aug 2012 06:50:31 GMT Subject: Re: [PATCH] fast_export.c: Fix a compiler warning Message-ID: <7vfw7im4zs.fsf@alter.siamese.dyndns.org> In-Reply-To: <2715225.vOk3BtNY6o@flomedio> Florian Achleitner writes: >> If you need to re-roll your patches in the 'fa/remote-svn' branch, could >> you please squash this fix into them. [This was implemented on top of >> commit 2ce959ba, but you will probably want to make the equivalent change >> to commit d319a37c ("Create a note for every imported commit containing >> svn metadata", 17-08-2012) instead. Note that, because of the context >> lines in the patch, it won't apply as-is.] > > Ok, I'll add it to the next version. This warning only occurs when building > for 32bit, thus I never saw it. There would be a format flag for printf that > sprecifies the platform's size_t integer type: "z". Yeah, I also queued 05ce866 (fixup: add missing cast to vcs-svn/fast_export.c, 2012-08-18) on top of your series before pushing 'pu' out yesterday. Have you had a chance to look at these fixups? There are others you would find in my tree, including minor log message typofixes.