From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Aug 2012 21:44:11 GMT
Subject: Re: [PATCH v5 15/16] remote-svn: add marks-file regeneration
Message-ID: <7vfw7fdiok.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1894713.otuKr9xS8H@flomedio>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

> On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> > I think you meant something like:
>> > 
>> >       init_notes(NULL, notes_ref, NULL, 0);
>> >
>> >         marksfile = fopen(marksfilename, "r");
>> >         if (!marksfile) {
>> >               regenerate_marks(marksfilename);
>> >                 marksfile = fopen(marksfilename, "r");
>
> Btw, this is FILE* is nowhere closed in your fixuped version in fa/remote-svn.

Please fix up things like that in your reroll.  I was doing minimum
fixes I noticed to get it compile before pushing it out as part of
'pu' (the alternative was simply not to merge and discard the
topic).

Thanks.