From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 11 Oct 2012 19:06:02 GMT
Subject: Re: [Patch v2 5/8] Prerequisites for creating nice html for all files in Documentation/howto
Message-ID: <7vfw5k7rs5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1873679011.46972.1349976139154.JavaMail.ngmail@webmail22.arcor-online.net>

Thomas Ackermann <th.acker66@arcor.de> writes:

>>From 2b9538990e30ae0911117c8e3d8b6891c9de31cf Mon Sep 17 00:00:00 2001
> From: Thomas Ackermann <th.acker@arcor.de>
> Date: Sat, 29 Sep 2012 17:28:54 +0200
> Subject: [PATCH] Prerequisites for creating nice html for all files in
>  Documentation/howto

These four lines are not needed; please remove them from all the patches.

> @@ -149,13 +152,13 @@ then
>  
>        info "Found matching head pattern: '$head_pattern'"
>        for group_pattern in $group_patterns; do
> -	for groupname in $groups; do
> -	  info "Checking group: '$groupname' against pattern: '$group_pattern'"
> -	  matchlen=$(expr "$groupname" : "$group_pattern")
> -	  if test "$matchlen" = "${#groupname}"
> -	  then
> -	    grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> -	  fi
> +	    for groupname in $groups; do
> +	      info "Checking group: '$groupname' against pattern: '$group_pattern'"
> +	      matchlen=$(expr "$groupname" : "$group_pattern")
> +	      if test "$matchlen" = "${#groupname}"
> +	      then
> +	        grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> +	      fi
>          done
>        done

The inner "done" does not seem to align with the "for ...; do" it
corresponds to, does it?