From: Junio C Hamano Date: Thu, 18 Oct 2012 09:17:01 GMT Subject: Re: [PATCH 3/6] pretty: prepare notes message at a centralized place Message-ID: <7vfw5cm96a.fsf@alter.siamese.dyndns.org> In-Reply-To: <20121018074921.GC9999@sigill.intra.peff.net> Jeff King writes: > It's possible that switching it would create bugs elsewhere (there are > over 100 uses of strbuf_detach, so maybe somebody really does want this > NULL behavior), but I tend to think it is just as likely to be fixing > undiscovered bugs. Yeah, I tend to agree. This "format-patch --notes" is obviously a post 1.8.0 topic, and so is the strbuf_detach() clean-up. Let me bookmark this thread in case it hasn't been resolved when I came back from my vacation, so that I won't forget ;-).