From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Mar 2013 17:01:20 GMT
Subject: Re: [RFC/PATCH] git-completion.bash: remove bashism to fix ZSH compatibility
Message-ID: <7vfw01an1b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqtxohubmb.fsf@grenoble-inp.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> So here is an updated based on your patch.
>
> Perfect, thanks.
>
>> The correct thing to do in the longer term may be to stop dot-sourcing
>> the source meant for bash into zsh, but this patch should suffice as
>> a band-aid in the meantime.
>
> I disagree with this particular part though. I think using the same code
> for bash and zsh makes sense, and it implies restricting to the common
> subset.

Having to restrict to the common subset means that whenever bash
adds new and useful features that this script could take advantage
of to improve the user experience, they cannot be employed until zsh
catches up (and worse yet, it is outside the control of this script
if zsh may ever catch up in the specific feature).