From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 Jul 2013 16:10:30 GMT
Subject: Re: [PATCH 3/3] wt-status: use "format" function attribute for status_printf
Message-ID: <7vfvvjoj2h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130710052859.GA5339@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Jul 09, 2013 at 10:26:04PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> ...
>> > I'm torn on this one. It really does provide us with more compile-time
>> > safety checks, but it's annoying that "-Wall -Werror" will no longer
>> > work out of the box.
>> 
>> Yeah, that is a show-stopper for me X-<.
>
> You can "fix" it with -Wno-zero-format-length, so the hassle is not
> huge. But I am also inclined to just drop this one. We have lived
> without the extra safety for a long time, and list review does tend to
> catch such problems in practice.

I am tempted to actually merge the original one as-is without any of
the workaround, and just tell people to use -Wno-format-zero-length.