From: Junio C Hamano Date: Fri, 27 May 2005 22:49:54 GMT Subject: [PATCH 01/12] Fix math thinko in similarity estimator. Message-ID: <7vekbs5lnx.fsf_-_@assigned-by-dhcp.cox.net> In-Reply-To: <7vk6lk5lxt.fsf_-_@assigned-by-dhcp.cox.net> The math to reject delta that is too big was confused. Signed-off-by: Junio C Hamano --- diffcore-rename.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/diffcore-rename.c b/diffcore-rename.c --- a/diffcore-rename.c +++ b/diffcore-rename.c @@ -163,7 +163,7 @@ static int estimate_similarity(struct di /* A delta that has a lot of literal additions would have * big delta_size no matter what else it does. */ - if (minimum_score < MAX_SCORE * delta_size / base_size) + if (base_size * (MAX_SCORE-minimum_score) < delta_size * MAX_SCORE) return 0; /* Estimate the edit size by interpreting delta. */ ------------------------------------------------