From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 04 Jul 2007 20:44:30 GMT
Subject: Re: [PATCH 2/2] diff: add custom regular expressions for function names
Message-ID: <7vejjnhpap.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <alpine.LFD.0.98.0707041140230.9434@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Wed, 4 Jul 2007, Johannes Schindelin wrote:
>> 
>> This patch introduces a config variable diff.functionNameRegexp
>> which replaces the default heuristics.  If the pattern contains
>> a group, the match of this group is used for the hunk header
>> instead of the whole match.
>
> Umm. Shouldn't it be a path-name based attribute instead?
>
> That way you can set it to be different things for different source files 
> in the same repository.. IOW, think mixed Java/C codebases.

Absolutely.  I'll take it from there.