From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 06 Jan 2008 10:51:24 GMT
Subject: Re: What's in git.git (stable frozen)
Message-ID: <7vejcv5is3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080106042935.GB4843@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This is a little uglier than it could be because the "colored" function
> does two things: correctly colorize a string, and check the global
> $use_color.

That fallout is a logical consequence of the semantics change of
color.interactive, which used to color the whole user experience
but now only covers about menus and stuff.  $use_color is still
tied to the former semantics.

It may make more sense to:

 * unset $prompt_color and friends when color.interactive says
   "not to color the menus";

 * unset $fraginfo_color and diff related ones when color.diff
   says "diff is monochrome";

upfront, and then change "sub colored" to just check if $color
is unset, instead of checking $use_color.