From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 18 Feb 2008 21:09:46 GMT
Subject: Re: [PATCH 4/4] Add a --cover-letter option to format-patch
Message-ID: <7vejbanf8l.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0802181254060.5816@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

>> > diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
>> > index 651efe6..53e6d2e 100644
>> > --- a/Documentation/git-format-patch.txt
>> > +++ b/Documentation/git-format-patch.txt
>> > @@ -17,6 +17,7 @@ SYNOPSIS
>> >                     [--in-reply-to=Message-Id] [--suffix=.<sfx>]
>> >                     [--ignore-if-in-upstream]
>> >                     [--subject-prefix=Subject-Prefix]
>> > +                   [--cover-letter]
>> >  		   [ <since> | <revision range> ]
>> 
>> Since you are already there, and it is really a small change, why not fix 
>> the whitespace?
>
> What *is* the correct whitespace for alignment in documentation?

The last time I checked, AsciiDoc output did not change before
and after running "expand" and then "unexpand" in all *.txt
files in Documentation/ directory, so if it is indenting to
multiple of 8, HT is fine.

Don't we have Documentation/.gitattributes that says indentation
to 8*N-th column must be done with N HTs these days?

>> Why not sign off the cover letter, too?
>
> I think cover letters aren't normally signed off, since they don't contain 
> any content that goes into the history.

Right.  They do not contain any content that needs DCO.