From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Jun 2008 15:14:44 GMT
Subject: Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers
Message-ID: <7vej7awq6z.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <87iqwmzwcn.fsf@osv.gnss.ru>

Sergei Organov <osv@javad.com> writes:

> Don't you think it's time to fix git-format-patch to put some reliable
> "end-of-patch" marker line before the signature?

Not at all.  git-apply is designed to (and has to) grok any reasonable
e-mailed patch, not just format-patch output.  And we should consider
having e-mail signature separator at the end as "reasonable".

It only becomes an issue when you start deviating from the rule of
reliable diff parsing, such as ignoring the old/new line count, which is
the topic of Dscho's patch.