From: Junio C Hamano Date: Mon, 08 Sep 2008 19:26:32 GMT Subject: Re: [PATCH] t6023-merge-file: Work around non-portable sed usage Message-ID: <7vej3ufnh3.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080908192313.GB4148@regex.yaph.org> arjen@yaph.org (Arjen Laarhoven) writes: > On Mon, Sep 08, 2008 at 02:06:02PM -0500, Brandon Casey wrote: > [...] >> I was just encountering this myself. >> >> sed can be fixed without the use of tr by replacing '\n' with an explicit newline like: >> >> sed -e 's/deerit./&\ >> \ >> \ >> \ >> /' -e "s/locavit,/locavit;/" < new6.txt > new8.txt >> >> Of course it doesn't fit on one line though. > > I don't think replacing 2 lines with 10 is a big win (not counting a > possible comment explaining why it's necessary). I'd rather replaced > the thing with a Perl one-liner though, but that seems a bit frowned > upon, correct? Perl one-liner is Ok, so are pregenerated test vectors in separate directory (i.e. ship with t/t6023/new6.txt file and refer to it from the test as "$TEST_DIRECTORY/t6023/new6.txt"), but I think your original patch to use % is perfectly fine for this one.