From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Jan 2009 07:02:15 GMT
Subject: Re: [RFC PATCH] diff --no-index: test for pager after option parsing
Message-ID: <7veizfbnuw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090107032013.GO21154@genesis.frugalware.org>

Miklos Vajna <vmiklos@frugalware.org> writes:

> On Tue, Jan 06, 2009 at 04:09:18PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
>> But I wonder if it still makes a difference in real life.idn't we stop
>> reporting the exit status from the pager some time ago?
>
> I just wanted to write this, I think that code could be just removed
> since ea27a18 (spawn pager via run_command interface, 2008-07-22).

I think we shouldn't.

People may already have got used to "git diff --exit-code" to disable the
pager, and doing the same for "git diff --exit-code --no-index" should be
with less surprises.

I'll queue the "--" fix, "-q" fix and this pager fix.  Thanks.