From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 08 May 2010 23:55:56 GMT
Subject: Re: [PATCH] cherry-pick: do not dump core when iconv fails
Message-ID: <7veihmaqyb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100508231729.GA6718@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

> When cherry-picking, usually the new and old commit encodings are both
> UTF-8.  Most old iconv implementations do not support this trivial
> conversion, so on old platforms, out->message remains NULL, and later
> attempts to read it segfault.

This agrees with what builtin/commit.c does around ll.896; even if the
encoding pair says "utf8" and "UTF-8", we would do the right thing.

Thanks.