From: Junio C Hamano Date: Mon, 29 Nov 2010 22:50:34 GMT Subject: Re: [PATCH] rebase: only show stat if configured to true Message-ID: <7veia3zqv9.fsf@alter.siamese.dyndns.org> In-Reply-To: <1289336340-28337-1-git-send-email-martin.von.zweigbergk@gmail.com> Martin von Zweigbergk writes: > If rebase.stat is set to true, a diffstat should be displayed. If it is > not set, it should default to false. However, if it is explicitly set to > false (or other value), a diffstat is still displayed, which is probably > not what most users would expect. Show diffstat only if it is set > to true. > > Signed-off-by: Martin von Zweigbergk > --- Sounds sensible; it would have been nicer if it came with a test, but this particular change is sort of obvious ;-) Thanks.