From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 Dec 2010 22:01:45 GMT
Subject: Re: [PATCHv2 4/7] web--browse: support opera, seamonkey and elinks
Message-ID: <7vei9yms6u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1291394861-11989-5-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

> -w3m|links|lynx|open)
> +w3m|elinks|links|lynx|open)
>  	eval "$browser_path" "$@"
>  	;;
>  start)
>  	exec "$browser_path" '"web-browse"' "$@"
>  	;;
> -dillo)
> +opera|dillo)
>  	"$browser_path" "$@" &
>  	;;

Not a complaint on your patch, but is there a reason we say "eval", "exec"
and "(nothing)" in these three case arms?

The above makes the interpretation of $browser_path and $@ inconsistent
between lynx family codepath (which would apply $IFS to find the browser)
and dillo and start family codepath (which would not), and I am wondering
if that difference is intended.