From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 May 2011 16:53:05 GMT
Subject: Re: [PATCH v3 0/3] Git commit --patch (again)
Message-ID: <7vei47q0i6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110509144451.GA11362@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I'm not sure if it is worth caring about. If you are really interested
> in index state, you are probably better off using "git add -p" and "git
> commit" separately.

I agree with this. I do not foresee myself using "commit -p" ever for this
exact reason. I however didn't see anything wrong in the series and I do
not see any reason to reject it, either. It's just another long rope other
people can use to tangle their neck with ;-).

> Hmm. Test t7501.8 explicitly tests that this isn't allowed. But the test
> is poorly written, and falsely returns success even with your patch.

Thanks. Let me see if I can simply amend what I queued already ;-)