From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 May 2011 18:57:04 GMT
Subject: Re: [PATCH] git-grep: Update tests (mainly for -P)
Message-ID: <7vei3pt3yj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1306064248-23092-1-git-send-email-michal.kiedrowicz@gmail.com>

Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:

> This patch adds few more tests to git-grep concerning the
> -P/--perl-regexp option.
>
> While at it, add some generic tests for grep.extendedRegexp config
> option, for detecting invalid regexep and check if "last one wins" rule
> works for selecting regexp type.
>
> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
> ---
> This is the promised update to tests and is meant to be applied on top of
> mk/grep-pcre.

Thanks, will queue.

>  t/t7810-grep.sh |   85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 85 insertions(+), 0 deletions(-)
>
> diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh
> index e845218..e061108 100755
> --- a/t/t7810-grep.sh
> +++ b/t/t7810-grep.sh
> @@ -32,6 +32,11 @@ test_expect_success setup '
>  		echo Hello_world
>  		echo HeLLo_world
>  	} >hello_world &&
> +	{
> +		echo aab
> +		echo a+b
> +		echo a\\+b
> +	} >ab &&

At some point it would be a good idea to clean these up to use either
cascading && or

	cat >ab <<\-EOF &&
        ...
        EOF

everywhere.