From: Junio C Hamano Date: Wed, 08 Jun 2011 23:48:23 GMT Subject: Re: [PATCH 04/19] teach remote-testgit to import non-HEAD refs Message-ID: <7vei3328c8.fsf@alter.siamese.dyndns.org> In-Reply-To: <1307558930-16074-5-git-send-email-srabbelier@gmail.com> Sverre Rabbelier writes: > From: Jeff King > > Upon receiving an "import" command, the testgit remote > helper would ignore the ref asked for by git and generate a > fast-export stream based on HEAD. Instead, we should > actually give git the ref it asked for. > > This requires adding a new parameter to the export_repo > method in the remote-helpers python library, which may be > used by code outside of git.git. We use a default parameter > so that callers without the new parameter will get the same > behavior as before. > > Signed-off-by: Sverre Rabbelier > --- > > Unchanged from Peff's series. This seems to be slightly different from what was sent to the list, though. Using refs=None as default and assigning ["HEAD"] is more in line with the standard Python practice, so the implementation is better. But "do we still append HEAD after --import-marks?" still stands.