From: Junio C Hamano Date: Wed, 13 Jul 2011 19:40:09 GMT Subject: Re: [RFC/PATCHv2 2/6] add metadata-cache infrastructure Message-ID: <7vei1u6kbq.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110713083139.GA26838@sigill.intra.peff.net> Jeff King writes: > I considered briefly that a zero-width cache might actually be useful > for storing a membership list (i.e., "is this sha1 in the list or not"). > But then you have no way of distinguishing "not in the list" from "have > no checked whether it should be in the list". You are probably better > off storing a single byte flag in such cases. Good reasoning; if you are going to add "BUG:zero width", the above is a good comment to have nearby. Thanks.