From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 09 Dec 2011 00:00:30 GMT
Subject: Re: [PATCH 5/6] t1510 (worktree): fix '&&' chaining
Message-ID: <7vehwehaw1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111208171213.GF2394@elie.hsd1.il.comcast.net>

Jonathan Nieder <jrnieder@gmail.com> writes:

> This is also not "Additionally", as in "As a separate change that
> maybe should have been another patch but I am too lazy".  Rather, it
> is a necessary change that is part of the same task.  So I would
> write:
>
> 	Breaks in a test assertion's && chain can potentially hide failures
> 	from earlier commands in the chain.  Fix these breaks.
>
> 	'unset' returns non-zero status when the variable passed was already
> 	unset on some shells, so now that the status is tested we need to
> 	change these instances to 'safe_unset'.
>
> Erm, sane_unset, not safe_unset.  Did you even test this?

Thanks for careful reading and many constructive review comments.