From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 Feb 2012 04:21:14 GMT
Subject: Re: What's cooking in git.git (Jan 2012, #08; Tue, 31)
Message-ID: <7vehudzwzp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vty3a2sf7.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> And of course the culprit turns out to be that "cute" expression.
>
> -- >8 --
> Subject: gitweb: do not use assignment with regexp replace in parameter
>
> A recent patch made the code to generate a parameter to git_get_projects_list
> a bit too cute, by introducing a new variable, assigning a value to it, and
> then munging that value with s/// replacement, all in the parameter list.
>
> The whole expression returns the number of replacements, not the resulting
> value in the variable after s/// operation.
>
> Split them into separate expressions, which also would make the resulting
> lines shorter and less taxing on the brain. 
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

I've squashed this in to the offending commit and merged the result to the
'next' branch.

Thanks.