From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Feb 2012 00:39:35 GMT
Subject: Re: [bug] blame duplicates trailing ">" in mailmapped emails
Message-ID: <7vehu8dcc8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120205234750.GA28735@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> We could also go as far as saying that map_user would _always_ terminate
> in this way (i.e., the caller gets a munged result, whether we found
> anything or not). Then internally, map_user could be simplified to stop
> worrying about making a temporary copy in mailbuf. And callers could
> simply call map_user without worrying about branching on whether it
> found anything or not.

I thought about it, but such a change needs to audit all the call sites
that assumes the promise original map_user() used to make before it was
broken. If we return 0 to the caller, the caller does not have to worry
about map_user() munging the buffer it lent to it.

It might be a worthwhile thing to do. I dunno; I didn't look into it.