From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 05 Jul 2012 23:18:38 GMT
Subject: Re: [PATCH 08/12] git-remote-mediawiki: change return type of get_mw_pages
Message-ID: <7vehoppzjl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1341473772-28023-9-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> The previous version was returning the list of pages to be fetched, but
> we are going to need an efficient membership test (i.e. is the page
> $title tracked), hence exposing a hash will be more convenient.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
>  contrib/mw-to-git/git-remote-mediawiki | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
> index 76b78bc..3f57598 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki
> +++ b/contrib/mw-to-git/git-remote-mediawiki
> @@ -377,7 +377,7 @@ sub get_mw_pages {
>  			get_all_mediafiles(\%pages);
>  		}
>  	}
> -	return values(%pages);
> +	return %pages;
>  }
>  
>  # usage: $out = run_git("command args");

This suggests the series is not based on 'master', which is not
fatal per-se ("am -3" guesses that came from b3d98595), but then
applying the series on mm/mediawiki-file-attachments topic will show
that the index line recorded in [PATCH 09/12] is useless.

On what commit was this meant to be applied???