From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Jul 2012 22:18:46 GMT
Subject: Re: [PATCH v3 6/7] Remove unused and bad gettext block from git-am
Message-ID: <7veho0erax.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120724212506.GA15798@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> I guess that means the intended justification is the following?
>
> 	The git am -d/--dotest option has errored out with a message
> 	since e72c7406 (am: remove support for -d .dotest, 2008-03-04).
> 	The error message about lack of support was eliminated along
> 	with other cleanups (probably by mistake) a year later by
> 	removing the option from the option table in 98ef23b3 (git-am:
> 	minor cleanups, 2009-01-28).
>
> 	But the code to handle -d and --dotest stayed around even though
> 	ever since then it could not be tripped.  Remove this dead code.
>
> 	Noticed because the error message starts with a '-' and
> 	xgettext does not cope well with that.

Looks good.