From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Jul 2012 15:51:51 GMT
Subject: Re: [PATCH] buitin_config: return postitive status in get_value
Message-ID: <7vehnts0vc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8CSXo-BsVsqNb4+f97ns30SuSn_iRJgEk=WjgGyEQaywQ@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> On Mon, Jul 30, 2012 at 3:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> +. You use '--global' option without $HOME being properly set (ret=128),
>> +. Any other errors (ret=7).
>
> To be pedantic, ret=128 is a result of die() and not setting $HOME is
> just one of them. There's also ret=129 for usage(), which is not
> documented. So maybe we can make it clear that we document some exit
> codes, but not all of them.
>
>> -This command will fail (with exit code ret) if:
>> +This command will fail with non-zero status if:
>
> "This command will fail with non-zero status. Some important exit codes are:"

Sounds good; will squash in.