From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Sep 2012 20:49:52 GMT
Subject: Re: [PATCH v3 05/14] Change fetch_pack() and friends to take string_list arguments
Message-ID: <7vehlzkqdr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120917221710.GA555@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> What I think would be much more productive is breaking apart gigantic
> includes like cache.h into more reasonable modules, which would mean
> less frequent recompilation when an uninteresting part of the header
> changes.

Ideally cache.h should cover what read-cache.c, sha1_file.c and
sha1_name.c do and need.  The parts related to sha1_name.c may
deserve to have its own header file, as its scope is fairly wide and
spans from low-level object name get_sha1_hex() to high level
parsing like dwim_ref().  Right now, the header also has pieces that
are needed only by connect.c and config.c (not even commented as
such), pager, base85, alloc, trace, add, piece of diff, etc.

Also we may want to move helper functions that are generally useful
and do not depend on specific command to more appropriate files.