From: Junio C Hamano Date: Fri, 07 Dec 2012 21:52:07 GMT Subject: Re: [PATCH 0/6] Improve remote helper documentation Message-ID: <7vehj1fs3c.fsf@alter.siamese.dyndns.org> In-Reply-To: Max Horn writes: > On 07.12.2012, at 20:09, Junio C Hamano wrote: > >> Except for a minor nit in 6/6; I think "defined options" should be >> "defined attributes". >> >> --- a/Documentation/git-remote-helpers.txt >> +++ b/Documentation/git-remote-helpers.txt >> @@ -227,6 +227,8 @@ Support for this command is mandatory. >> the name; unrecognized attributes are ignored. The list ends >> with a blank line. >> + >> +See REF LIST ATTRIBUTES for a list of currently defined options. >> ++ > > Indeed, my mistake. Dumb question since I am still not completely > familiar with the procedures here: Would you just fix this > yourself as you apply this, or is it better (or even required) > that I reroll for this? (Of course if I ned to re-roll for other > reasons, I'd fix this one as well). I didn't see any other issues myself, and I didn't see anybody raising issues on the series, either, so I could fix it up by amending what is already queued, as long as you are OK with it. Thanks.