From: Junio C Hamano <junio@pobox.com>
Date: Tue, 18 Jun 2013 14:27:57 GMT
Subject: Re: [PATCH 1/2] sha1_name: stop hard-coding 40-character hex checks
Message-ID: <7vehbza3yq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0=_Ac+dQV23xiXty3peWdhn2iFzgSPb7LYDFmoCzYhxQQ@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Phil Hord wrote:
>> I share your disdain for the bare '40's in the code.  But I think this
>> code is less clear than the previous version with the magic number.
>
> Please read the cover-letter: 

Which was...

>> [1/2] is important.  [2/2] is a minor prettification, that wouldn't
>> have been possible without [1/2].

...and I do not find how the above is connected with

> I was just toying around to see if this
> was a good idea,...

...this in any way.  Puzzled.