From: Junio C Hamano <junkio@cox.net>
Date: Sat, 21 May 2005 17:24:57 GMT
Subject: Re: [PATCH] Fix use of wc in t0000-basic
Message-ID: <7vd5rkij9y.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050521110129.GA7924@gondor.apana.org.au>

>>>>> "HX" == Herbert Xu <herbert@gondor.apana.org.au> writes:

HX> Are you sure that it didn't ignore the leading spaces with -eq?
HX> The code in question just calls strtol.

Sorry, I am not sure whose fault it was, and the recollection
comes from my distant past.  It could have been that the
smallish shell in that semi-embedded environment had an
incompatible built-in "test" command which was burning me, but
I distinctively remember changing many of the vendor supplied
shell script that had:

    if test " $number" -eq 3
    then
        ...

either stripping dq around it or simply removing the space from
there, depending on how that $number was generated.

Since I assume we are only talking about portability across
POSIXy world I do not think this is a big issue.