From: Junio C Hamano <junkio@cox.net>
Date: Mon, 28 Nov 2005 18:31:05 GMT
Subject: Re: use binmode(STDOUT) in git-status
Message-ID: <7vd5kkvd3q.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0511272334w393434e7lad3e3b102e6c3e9e@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

> Activision's Perl generates CRLF unless STDOUT is binmoded, which is
> inconsistent with other output of git-status.

I do not think this is a kind of patch that I should accept to
apply to the generic part of the codepath, even if on sane
platforms binmode() could be a no-op.

You should not have to say binmode() when you are emitting plain
text (otherwise you have to say that everywhere which is
madness).  I presume the Cygwin version uses Perl from Cygwin
and would not have this problem?

If that is the case, maybe this patch should be maintained out
of tree by the maintainer of Windows port of git that does _not_
use Cygwin but ActiveState.