From: Junio C Hamano Date: Tue, 31 Jan 2006 17:49:53 GMT Subject: Re: [PATCH] Shallow clone: low level machinery. Message-ID: <7vd5i81e4e.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > apart from my thinking this is not backward-compatible (you are supposed > to be able to pull from a complete repo, even if it has a > non-shallow-capable upload-pack), here are my comments: It cannot do a shallow clone against older servers, no. I think it should be able to do a full clone from older servers, but I need to double check -- at least that is how I meant to write that thing but it was late night ;-). > - it is good that MAXPARENT and struct commit_graft are in more public > places now. > > - reparse_* is misleading. Nothing is reparsed, but rather "unparsed". I meant to reparse them thear but forgot. Will remember to fix. > - I'd hesitate to let git-daemon write temporary files. That is a whole > new can of security worms. > > - The custom_graft issue could be handled in a more elegant manner if > git was lib'ified (no temporary file). Since that is already the > plan, why not do that first, and come back later? That is why it does not write any temporary files. It introduces a way to read graft information from an environment variable. > - It looks wrong to me to define MAX_PARENTS as 20 in upload-pack.c, when > MAXPARENT is defined as 16 in cache.h. This is remnant from my earlier one that did not move MAXPARENT out from commit-tree I forgot to clean up before calling it a day. Will remember to clean up.