From: Junio C Hamano <junkio@cox.net>
Date: Wed, 23 Aug 2006 01:34:16 GMT
Subject: Re: [PATCH] git-send-email: Don't set author_not_sender from Cc: lines
Message-ID: <7vd5asjkvb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1156253919761-git-send-email-hskinnemoen@atmel.com>

Haavard Skinnemoen <hskinnemoen@atmel.com> writes:

> When an mbox-style patch contains a Cc: line in the header,
> git-send-email will check the address against the sender specified
> on the command line. If they don't match, sender_not_author will
> be set to the address obtained from the Cc line.

> @@ -506,7 +506,7 @@ foreach my $t (@files) {
>  				if (/^Subject:\s+(.*)$/) {
>  					$subject = $1;
>  
> -				} elsif (/^(Cc|From):\s+(.*)$/) {
> +				} elsif (/^(From):\s+(.*)$/) {
>  					if ($2 eq $from) {
>  						next if ($suppress_from);
>  					}
> @@ -516,8 +516,11 @@ foreach my $t (@files) {
>  					printf("(mbox) Adding cc: %s from line '%s'\n",
>  						$2, $_) unless $quiet;
>  					push @cc, $2;
> +				} elsif (/^(Cc):\s+(.*)$/) {
> +					printf("(mbox) Adding cc: %s from line '%s'\n",
> +						$2, $_) unless $quiet;
> +					push @cc, $2;
>  				}
> -
>  			} else {
>  				# In the traditional
>  				# "send lots of email" format,

The patch looks wrong.  If your name is on CC: and you want to
suppress sending to yourself what happens?

How about doing something like this instead?

diff --git a/git-send-email.perl b/git-send-email.perl
index a83c7e9..8adb6b9 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -510,7 +510,7 @@ foreach my $t (@files) {
 					if ($2 eq $from) {
 						next if ($suppress_from);
 					}
-					else {
+					elsif ($1 eq 'From') {
 						$author_not_sender = $2;
 					}
 					printf("(mbox) Adding cc: %s from line '%s'\n",