From: Junio C Hamano <junkio@cox.net>
Date: Sat, 10 Feb 2007 15:13:37 GMT
Subject: Re: [PATCH 1/2] run_diff_{files,index}(): update calling convention.
Message-ID: <7vd54im4f2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <e5bfff550702100325v5ce9ba1fx4b9b7adcc5040948@mail.gmail.com>

"Marco Costalba" <mcostalba@gmail.com> writes:

> So in this case your patch that introduce '--refresh' option in 'git
> runstatus' is not just a shortcut for 'git update-index' + 'git
> runstatus' but adds some real value.
>
> One more reason for asking you to add it before 1.5 release ;-)

The thing is, it touches central part of the system by changing
the calling convention of two rather important functions.  You
might have already fully tested that there is no regression for
git-runstatus, but it affects other callers as well.  I tried to
be careful when I did the conversion but I am not 100% sure
there is no "unintended side effects".