From: Junio C Hamano Date: Mon, 26 Mar 2007 20:27:15 GMT Subject: Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX Message-ID: <7vd52vwy1o.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <17928.7076.871485.136142@lisa.zopyra.com> Bill Lear writes: > On Monday, March 26, 2007 at 01:44:34 (-0700) Junio C Hamano writes: >>"Shawn O. Pearce" writes: >> >>> Junio C Hamano wrote: >>>> Eygene Ryabinkin writes: >>>> >>>> > Remove unnecessary '-S' option that enabled less to chop long lines. >>>> > It used to provide some confusion at least for the 'git diff': >>>> > "Where are my long lines? Are they missed from the patch?". >>>> >>>> It is not "unnecessary", but only "what _you_ are not used to". >>>> As this breaks expectentions of people already familiar with >>>> what git does by default, I cannot take this patch. >>> >>> Hear hear. I completely agree with Junio. I (and a number of >>> other users that I work with) expect this behevaior by default. >> >>Two tips. >> >> (1) Learn to use left/right arrow keys under "less -S" if you >> have occasional lines that are too long. > > Hmm, looking at the code: why, if the environment variable LESS is > already set, should this all be worth talking about? Shouldn't the > user be able to set LESS to whatever they want, once, and be done with > it? The current setenv() call to set up the pager does this, correct? Yes. That would make the third tip ;-).